Update how DLQ subscriber is instantiated (GSI-1274) #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use case for the DLQ subscribers involves using many of them at once, for which the construction model of the regular
KafkaEventSubscriber
is ill-suited. This PR ditches theconstruct
method in favor of a normal__init__
and explicitstart()
,stop()
. I also included the async context manager functions (__aenter__()
/__aexit__()
) to call start and stop since this is helpful for tests where there might only be one subscriber.I also updated
test_dlqsub.py
to use the blanketpytestmark
since there was only one sync function.