Bug including resource in multiple resources #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 2, 2019 15:30
1 similar comment
safo6m
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a certain resource is included in the response and is a relation for multiple resources, it is only included in the angular2-jsonapi models once.
To explain I've created a test that fails on the current master branch, and is resolved in my fix.
I've added a category entity, which represents the category of a book.
If I request an author, with include=books.category.books, the following is happens:
This is caused by methods getBelongsToRelationship and getHasManyRelationship. They look for the relationship in the remainingModels array where they should be looking in the included array.