Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override accept/content-type headers instead of adding. fixes #39 #40

Merged
merged 3 commits into from
Oct 20, 2016

Conversation

HennerM
Copy link
Collaborator

@HennerM HennerM commented Oct 19, 2016

The Content-Type and Accept request headers were appened, therefore the value wos concatenated, as reported in #39

@coveralls
Copy link

coveralls commented Oct 19, 2016

Coverage Status

Coverage remained the same at 53.872% when pulling 8f6060b on HennerM:fix-duplicate-headers into dbbb34d on ghidoz:master.

@coveralls
Copy link

coveralls commented Oct 19, 2016

Coverage Status

Coverage remained the same at 53.872% when pulling 3540202 on HennerM:fix-duplicate-headers into dbbb34d on ghidoz:master.

@HennerM
Copy link
Collaborator Author

HennerM commented Oct 19, 2016

I realised that the per-request headers are also appended on every following request and I think that this might not be the desired behaviour. Therefore I added a commit that fixes this and allows overriding the Accept and Content-Type header also.

@coveralls
Copy link

coveralls commented Oct 19, 2016

Coverage Status

Coverage decreased (-0.5%) to 53.333% when pulling 5d38c52 on HennerM:fix-duplicate-headers into dbbb34d on ghidoz:master.

@ghidoz
Copy link
Owner

ghidoz commented Oct 20, 2016

Perfect, thanks! 👍

@ghidoz ghidoz merged commit 5c1f984 into ghidoz:master Oct 20, 2016
@HennerM HennerM deleted the fix-duplicate-headers branch March 16, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants