Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: externalResouces should also work globally #1330

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Dec 15, 2023

- relates to issue #1329 even though the issue was brought for the new v7, this regression was also pushed on last v6.6.5 so a fix is necessary on v6 as well
@ghiscoding ghiscoding changed the base branch from master to version6 December 15, 2023 20:41
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (version6@d5e6060). Click here to learn what that means.

Additional details and impacted files
@@             Coverage Diff              @@
##             version6     #1330   +/-   ##
============================================
  Coverage            ?   100.00%           
============================================
  Files               ?         7           
  Lines               ?       909           
  Branches            ?       304           
============================================
  Hits                ?       909           
  Misses              ?         0           
  Partials            ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding merged commit 67f70af into version6 Dec 15, 2023
4 checks passed
@ghiscoding ghiscoding deleted the bugfix/global-register-resource-v4 branch December 15, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant