Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to SASS @use and remove any @import to fix SASS deprecations #308

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

ghiscoding
Copy link
Owner

@ghiscoding ghiscoding commented Oct 23, 2024

Replace all @imports with @use since this will be removed in dart-sass 2.0, see https://sass-lang.com/blog/import-is-deprecated/

Copy link

stackblitz bot commented Oct 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

Playwright E2E Test Results

78 tests  ±0   78 ✅ ±0   1m 51s ⏱️ +5s
69 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit c7654ca. ± Comparison against base commit f5bba00.

@ghiscoding ghiscoding merged commit 186d21a into main Oct 23, 2024
3 checks passed
@ghiscoding ghiscoding deleted the bugfix/sass-import-use branch October 23, 2024 02:44
@ghiscoding ghiscoding changed the title feat: support @use by replacing @import to fix SASS deprecations feat: switch to SASS @use and remove any @import to fix SASS deprecations Oct 23, 2024
ghiscoding added a commit that referenced this pull request Oct 24, 2024
in a previous commit b0e5d4d that fixed a typo introduced in PR #308, it actually only fixed the typo but in reality the typo was caused by a search & replace text and the `div.ms-icon-x` ended up dropping the `div.`, so we should probably add the div selector back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant