Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace some DOM Element method not supported in Salesforce #84

Merged
merged 2 commits into from
Jun 28, 2023

Conversation

ghiscoding
Copy link
Owner

some methods aren't supported in Salesforce for unknown reasons and it throws some errors like "append function does not exist"

some methods aren't supported in Salesforce for unknown reasons and it throws some errors like "append function does not exist"
the elements are already in `if` conditions, so no need to use optional chaining `?.`
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

🎭 Playwright Summary - Success 🎉

Playwright Report

[email protected] test:e2e /home/runner/work/multiple-select-vanilla/multiple-select-vanilla
playwright test --config playwright/playwright.config.ts

Running 66 tests using 1 worker
··································································
66 passed (1.3m)

@ghiscoding ghiscoding merged commit 2617514 into main Jun 28, 2023
@ghiscoding ghiscoding deleted the bugfix/salesforce-unsupported-node-methods branch June 28, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant