Skip to content

Commit

Permalink
fix: remove Font-Awesome dependency
Browse files Browse the repository at this point in the history
- forgot to remove Font-Awesome dependency
  • Loading branch information
ghiscoding committed May 10, 2024
1 parent fe0f4b7 commit 6463b5d
Show file tree
Hide file tree
Showing 7 changed files with 221 additions and 312 deletions.
1 change: 0 additions & 1 deletion docs/TOC.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

* [Dark Mode](styling/dark-mode.md)
* [Styling CSS/SASS/Themes](styling/styling.md)
* [SVG Icons](styling/svg-icons.md)

## Column Functionalities

Expand Down
2 changes: 1 addition & 1 deletion docs/column-functionalities/formatters.md
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ export interface FormatterResultObject {

#### Example of a Custom Formatter with HTML string

For example, we will use `Font-Awesome` with a `boolean` as input data, and display a (fire) icon when `True` or a (snowflake) when `False`. This custom formatter is actually display in the [UI sample](#ui-sample) shown below.
For example, we will use our optional SVG icons `.mdi` with a `boolean` as input data, and display a (fire) icon when `True` or a (snowflake) when `False`. This custom formatter is actually display in the [UI sample](#ui-sample) shown below.

```ts
// create a custom Formatter with the Formatter type
Expand Down
5 changes: 2 additions & 3 deletions docs/getting-started/quick-start.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,15 @@
The easiest is to simply clone the [Slickgrid-React-Demos](https://github.com/ghiscoding/slickgrid-react-demos) project and run it from there... or if you really wish to start from scratch then follow the steps below.

### 1. Install NPM Package
Install `React`, `Slickgrid-React`, `Bootstrap` (or other UI framework) and potentially a font library like `Font-Awesome`
Install `React`, `Slickgrid-React`, `Bootstrap` (or other UI framework)
```bash
npm install --save slickgrid-react bootstrap
# or with yarn add
```
_Note: `Bootstrap` and `Font-Awesome` are both optional, you can use any other libs too_
_Note: `Bootstrap` is optional, you can use any other framework_

### 2. Import all necessary dependencies in `main.ts`
```tsx
import 'font-awesome/css/font-awesome.css';
import 'bootstrap/dist/css/bootstrap.min.css';
import 'bootstrap';
import i18n from 'i18next';
Expand Down
255 changes: 213 additions & 42 deletions docs/styling/styling.md

Large diffs are not rendered by default.

228 changes: 0 additions & 228 deletions docs/styling/svg-icons.md

This file was deleted.

6 changes: 2 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,7 @@
"@slickgrid-universal/event-pub-sub": "~5.0.0",
"@slickgrid-universal/pagination-component": "~5.0.0",
"dequal": "^2.0.3",
"font-awesome": "^4.7.0",
"i18next": "^23.11.3",
"regenerator-runtime": "^0.14.1",
"sortablejs": "^1.15.2"
},
"devDependencies": {
Expand Down Expand Up @@ -142,7 +140,6 @@
"eslint-plugin-n": "^17.5.1",
"eslint-plugin-prefer-arrow": "^1.2.3",
"fetch-jsonp": "^1.3.0",
"font-awesome": "^4.7.0",
"html-loader": "5.0.0",
"html-webpack-plugin": "5.6.0",
"i18next-http-backend": "^2.5.1",
Expand All @@ -159,6 +156,7 @@
"react-dom": "^18.3.1",
"react-i18next": "^14.1.1",
"react-router-dom": "^6.23.0",
"regenerator-runtime": "^0.14.1",
"release-it": "^17.2.1",
"rimraf": "^5.0.5",
"rxjs": "^7.8.1",
Expand All @@ -181,4 +179,4 @@
"resolutions": {
"caniuse-lite": "1.0.30001617"
}
}
}
Loading

0 comments on commit 6463b5d

Please sign in to comment.