-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos tests #862 #3
base: macos
Are you sure you want to change the base?
Conversation
Added option to make rabbitmq work in vagrant environments with voxpupuli module Install also archive module for puppet/rabbitmq setup Added option to make rabbitmq work in vagrant environments with voxpupuli module Re-removed puppetlabs references Removed redundant puppet module command in tests scripts
spec testes for sensu::server::service should show that when the kernel is linux, the 'sensu-server' service resource is present with all the attributes and when the kernel is Darwin or windows the 'sensu-server' service is not present. |
|
||
context 'default' do | ||
directories.each do |dir| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a test to show that the contents of /etc/default/sensu
is EMBEDDED_RUBY=true
https://github.com/sensu/sensu-puppet/pull/863/files#diff-1576180ba8964fff8d837b3256127ebcR206
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added here 6575759
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added missing tests in 6575759
spec/classes/sensu_transport_spec.rb
Outdated
end | ||
|
||
it { should create_class('sensu::transport') } | ||
it { should contain_file('/etc/sensu/conf.d/transport.json') } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with ensure
attribute set to 'present'. This is important since the logic dictates the ensure attribute. No need to specify the other attributes.
Awesome work @alvagante !! |
Thanks @alvagante !! When this is ready, please squash your commits and let me know and I'll get this merged. Excited to see MacOS support. |
Added spec tests for MacOS/Darwin More tests added tests for darwin and windows for sensu::server::service More darwin tests
No description provided.