-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue mode 2031 DSR when config is reloaded #3965
Comments
With #3994 merged, I think we still need to issue a 2031 DSR report when the configuration is reloaded. We can probably safely do this every time the config is reloaded (without checking if any colors actually changed) since that isn't a frequent activity. I'm renaming the issue for that. |
cc @gpanders to the above |
Doesn’t it already do this? I am pretty sure I tested this when testing #3994, though I will double check again when back at my computer. EDIT: Just double checked and yes, the DSR is sent when the config is reloaded. |
Discussed in #3933
Originally posted by gpanders December 29, 2024
After discussion in the Contour issue tracker and in Ghostty's Discord, @christianparpart suggested that Ghostty should not be sending mode 2031 DSRs when any color changes based on a VT sequence (e.g. an OSC 10/11/12 sequence). DSRs should only be sent when the color palette changes because of a config reload or system event such as a transition from light to dark mode.
For Neovim this would solve the issue of receiving too many DSRs (we currently get one every time the cursor color changes, which can be quite frequent based on the user's
'guicursor'
setting).The text was updated successfully, but these errors were encountered: