gtk: add context menu to libadwaita tab headers #2529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, setting up the machinery is helpful, but I don't think reusing the surface context menu is particularly useful and I can see it being confusing with splits (since its unclear if you click an unfocused tab what happens when you say... split-right). I think if you're interested, please go ahead and make a dedicated tab context menu and we can start with maybe just "Close Tab" as an option. Going forward there are a number of things we can then add in there. |
|
OK, working on this. Hopefully have it done later today, but I introduced a crash somehow so I need to track that down first. |
jcollie
force-pushed
the
gtk-adw-tab-header-context-menu
branch
from
76207f3 to
6c97ee8
Compare
jcollie
force-pushed
the
gtk-adw-tab-header-context-menu
branch
from
6c97ee8 to
3e84950
Compare
The preferred method to enable/disable menu options is to enable/disable the associated actions.
Put GTK and libadwaita notebook implementations into separate structs/ files for clarity.
jcollie
force-pushed
the
gtk-adw-tab-header-context-menu
branch
from
3e84950 to
0d0775d
Compare
|
closing, will resubmit once notebook refactor is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-uses the context menu from the main app.