-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] PR #2096 in release 5.9.2 cause to exception #2138
Comments
What's the error? Do you have anything (error, traceback...) to paste? |
I lost a log when fallback to 5.9.1 but will re-update and share full log with you. The main point that this particular function was the last in stacktrace and fallback to previous version fix error - where this call doesn't exists. But anyway will reproduce today again for you |
@giampaolo as I promised - here is the log:
|
Same error while using jupyterlab |
Same issue trying to use https://github.com/nvbn/thefuck (looks like this isn't just one program, it's something to do with anything that uses 'psutil')
Edit: looks like it has something to do with this line (only place I found "ethtool_cmd_speed" in this project): Line 444 in d4eea1f
Edit 2: Searching for that function on all of Github leads to this patch file in the |
Fixed it in b88f4d8. Please confirm it patch works. |
@giampaolo that commit fixes it for me on Termux (Android), using this line in requirements file:
...however the package doesn't really work as it does on other platforms (I know this is expected) and I'm now hitting issues similar to #1334:
|
Summary
Description
Using home-assistant native on Android - cause module "Hardware" to fail.
Fallback to 5.9.1 make it work flawlessly.
Debug logs trace back to
psutil
and this function call:d4eea1f#diff-300fc786f9e87417b39f07b9b5d0940fac8ef6098047cf8f46e9d0678edb2b6dR444
Looks like there is environments and kernels where there is no
ethtool_cmd_speed
function available and it's call cause exception to be thrown.I'm not an expert in this codebase, but assume we may
try/catch
that call and fallback to previous variant. Thanks in advance for devs who pick up this issue. Ping me if you need any other informationThe text was updated successfully, but these errors were encountered: