Handle alternate NT path forms #2495
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giampaolo
requested changes
Jan 3, 2025
`convert_dos_path` does not currently handle UNC paths or paths of the form `\??\X:` (as returned by Wine). This results in the `psutil/tests/test_process.py::TestProcess::test_exe` test failing in the following cases: * Python is run from a network share; or * The tests are performed under Wine on a drive other than the one Python is installed on. Add handling for the following NT path forms: * `\\server\share` * `\Device\Mup\server\share` -> `\\server\share` * `\??\UNC\server\share` -> `\\server\share` * `\??\X:` -> `X:` Signed-off-by: Ben Peddell <[email protected]>
klightspeed
force-pushed
the
convert_dos_path-handle-nt-path
branch
from
b38f747 to
305bb78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
convert_dos_path#2494Description
convert_dos_pathdoes not currently handle UNC paths or paths of the form\??\X:(as returned by Wine). This results in thepsutil/tests/test_process.py::TestProcess::test_exetest failing in the following cases:Add handling for the following NT path forms:
\\server\share\Device\Mup\server\share->\\server\share\??\UNC\server\share->\\server\share\??\X:->X: