Fix error checking to avoid calling NtQueryObject on bad objects #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giampaolo
added a commit
that referenced
this pull request
Jul 15, 2014
Fix error checking to avoid calling NtQueryObject on bad objects
|
It seems it worked. Thanks a lot Jeff. It appears you solved a very long standing issue. |
|
Yes thank you very much. I had abandoned a project because of this. Now I can go back to it. TY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing a code review of my previous changes I spotted an error in the condition checking.
GetLastError was never called before checking the error value.
I was able to successfully cause psutil 2.1.1 (PyPi) on Python 3.4.1 to hang by calling get_open_files(). After this patch, get_open_files() returns the correct results.
This should solve issue #340