Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add PodLogs template #55

Merged
merged 9 commits into from
Oct 8, 2024
Merged

add PodLogs template #55

merged 9 commits into from
Oct 8, 2024

Conversation

TheoBrigitte
Copy link
Member

@TheoBrigitte TheoBrigitte commented Oct 1, 2024

Towards: giantswarm/roadmap#3518

Add PodLogs template to allow passing PodLogs resources via helm chart values. This is required in our setup in order to be able to create PodLogs in the same cluster where Alloy is deployed.

@TheoBrigitte TheoBrigitte self-assigned this Oct 1, 2024
  * Error: template: alloy/templates/podlogs.yaml:9:8: executing "alloy/templates/podlogs.yaml" at <include "alloy.labels" .>: error calling include: template: alloy/templates/_helpers.tpl:5:18: executing "alloy.labels" at <include "alloy.chart" .>: error calling include: template: alloy/charts/alloy/templates/_helpers.tpl:30:7: executing "alloy.chart" at <index .Values "$chart_tests">: error calling index: index of untyped nil
@TheoBrigitte TheoBrigitte marked this pull request as ready for review October 7, 2024 15:16
@TheoBrigitte TheoBrigitte requested a review from a team as a code owner October 7, 2024 15:16
Copy link

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheoBrigitte TheoBrigitte merged commit 8470f10 into main Oct 8, 2024
7 checks passed
@TheoBrigitte TheoBrigitte deleted the podlogs branch October 8, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants