Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vsphere permissions #2327

Merged
merged 2 commits into from
Oct 31, 2024
Merged

update vsphere permissions #2327

merged 2 commits into from
Oct 31, 2024

Conversation

vxav
Copy link
Contributor

@vxav vxav commented Oct 31, 2024

What this PR does / why we need it

Things to check/remember before submitting

  • If you made content changes

    • Run make lint dev to render and proofread content changes locally.
    • Bump last_review_date in the front matter header if you reviewed the entire page.

@vxav vxav requested a review from glitchcrab October 31, 2024 12:00
@vxav vxav requested a review from a team as a code owner October 31, 2024 12:00
pipo02mix
pipo02mix approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@pipo02mix pipo02mix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@vxav vxav merged commit 37ab628 into main Oct 31, 2024
8 checks passed
@vxav vxav deleted the vxav-patch-1 branch October 31, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pipo02mix pipo02mix pipo02mix approved these changes

@glitchcrab glitchcrab Awaiting requested review from glitchcrab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vxav @pipo02mix