Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPI: Request observability-bundle >= 1.7.0. #1468

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

TheoBrigitte
Copy link
Member

@TheoBrigitte TheoBrigitte commented Oct 24, 2024

Towards: giantswarm/roadmap#3518

This PR update the releases requests to make sure we upgrade observability-bundle to v1.7.0 in newer releases

@TheoBrigitte TheoBrigitte requested a review from a team as a code owner October 24, 2024 12:53
@TheoBrigitte TheoBrigitte self-assigned this Oct 24, 2024
@TheoBrigitte TheoBrigitte requested review from a team October 24, 2024 12:53
Copy link
Member

@Gacko Gacko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot introduce this in CAPV v28.0.1 nor v29.0.0. There should not be any app changes for < v29.0.0 and CAPV v29.0.0 itself should first get into alignment with what we currently have in the latest releases of other providers.

So for CAPV, we could integrate observability-bundle v1.7.0 in CAPV v29.1.0 earliest.

I already talked to Nick about this and we agreed on first getting to a point where all CAPI providers use the same app versions + latest patches of Flatcar, Kubernetes and OS Tooling. This means we'll probably also forge a CAPA v29.3.1 and CAPZ v29.2.1.

Since CAPA v29.3.1 and CAPZ v29.2.1 would match the semver comparison you're introducing here and we do not ship minor app bumps in patch releases, I'd ask you to first request observability-bundle v1.7.0 for CAPA v29.4.0, CAPZ v29.3.0 and CAPV v29.1.0 by using >= 29.4.0, >= 29.3.0 and >= 29.1.0 as with > 29.3.0, > 29.2.0 and > 29.0.0 you would also request it for patch releases.

@TheoBrigitte
Copy link
Member Author

Alright I updated the requirements accordingly

@Gacko Gacko changed the title request observability-bundle >= 1.7.0 on new releases CAPI: Request observability-bundle >= 1.7.0. Oct 24, 2024
@Gacko Gacko added the skip/ci Instructs PR Gatekeeper to ignore any required PR checks label Oct 24, 2024
@Gacko Gacko force-pushed the observability-bundle-1.7.0 branch from 037458d to 47864ab Compare October 24, 2024 20:47
@Gacko Gacko merged commit b5eb7a5 into master Oct 24, 2024
10 of 11 checks passed
@Gacko Gacko deleted the observability-bundle-1.7.0 branch October 24, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs PR Gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants