-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin forms layout fills screen width #2108
Draft
luistoptal
wants to merge
13
commits into
gigascience:develop
Choose a base branch
from
luistoptal:new-feature/2100-improve-screen-usage-on-admin-pages
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Admin forms layout fills screen width #2108
luistoptal
wants to merge
13
commits into
gigascience:develop
from
luistoptal:new-feature/2100-improve-screen-usage-on-admin-pages
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age-on-admin-pages
…age-on-admin-pages
luistoptal
force-pushed
the
new-feature/2100-improve-screen-usage-on-admin-pages
branch
from
January 4, 2025 09:47
11f71bc
to
7fc239d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #2100
IMPORTANT: #2168 extends this PR by updating all the forms to the well layout type. We might merge this PR if we prefer the unwrapped layout or merge #2168 if we prefer the wrapped layout
Unwrapped layout (this PR)
Wrapped layout (#2168)
As per the comments in #2100 the wrapped layout is preferred
Updated all admin forms to make use of a wider region of the page
How to test?
How have functionalities been implemented?
Any issues with implementation?
there is no way to apply these layout changes consistently while keeping all forms looking great, there are forms with just 2 or 3 fields which leave blank space in the page no matter what layout is adopted
I still think a wide layout looks better generally speaking
Any changes to automated tests?
All existing tests pass