Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin forms layout fills screen width #2108

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

luistoptal
Copy link
Collaborator

@luistoptal luistoptal commented Nov 23, 2024

Pull request for issue: #2100

IMPORTANT: #2168 extends this PR by updating all the forms to the well layout type. We might merge this PR if we prefer the unwrapped layout or merge #2168 if we prefer the wrapped layout

Unwrapped layout (this PR)
image

Wrapped layout (#2168)
image

As per the comments in #2100 the wrapped layout is preferred

Updated all admin forms to make use of a wider region of the page

How to test?

  • there are no changes in the html and functionality so all existing tests should pass
  • navigate to each admin form (except dataset) and verify layout now fills the horizontal space available

How have functionalities been implemented?

  • used different bootstrap classes to use wider responsive layouts
  • on mobile, layout becomes a column
  • field widths were weighted taking into account visual balance and field type, varying between one, two and three columns, depending on the case
  • I opted to add an additional button style to keep button widths more consistant

Any issues with implementation?

there is no way to apply these layout changes consistently while keeping all forms looking great, there are forms with just 2 or 3 fields which leave blank space in the page no matter what layout is adopted

I still think a wide layout looks better generally speaking

Any changes to automated tests?

All existing tests pass

@luistoptal luistoptal force-pushed the new-feature/2100-improve-screen-usage-on-admin-pages branch from 11f71bc to 7fc239d Compare January 4, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant