Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #2066
IMPORTANT: this is a follow up of #2082, please merge that PR before this one
Wrap the edit attr form in a modal (see comments in #2082 (review)) so that the layout and UX is a bit less cramped and (hopefully) more straightforward, and to easily solve the layout issue expressed in the conversation
How to test?
How have functionalities been implemented?
Wrapped the edit form in a modal that gets rendered with the reponse from the
actionEditAttr
method of the controller, everything else remains unchanged.A test was removed since it tested an edge case which is no longer possible. The test checked that a fringe interaction (new attribute and edit attribute being used simultaneously) did not lead to errors. I think the fact that we can remove that test is a good indication at this edge case is no longer possible, as the new layout restricts the user to handle the editted attribute before doing anything else
Any changes to automated tests?
One test was deleted, other tests stay the same as the actions to edit attributes stay the same