Add no-save feature #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morishin
commented
May 16, 2017
Sources/ToyboxKit/Handler.swift
Outdated
| public var rootURL: URL { | ||
| return Workspace.rootURL | ||
| } | ||
|
|
||
| public init() { | ||
| executeAutoremove() |
There was a problem hiding this comment.
This is in the initializer because I want to remove files every command execution. Do you have any better idea?
Merged
morishin
force-pushed
the
autoremove-feature
branch
from
3394222 to
c491bb4
Compare
morishin
force-pushed
the
autoremove-feature
branch
from
c491bb4 to
01e149b
Compare
morishin
force-pushed
the
autoremove-feature
branch
from
01e149b to
68b1522
Compare
giginet
approved these changes
May 17, 2017
Sources/toybox/Commands/Create.swift
Outdated
| @@ -38,6 +40,7 @@ struct CreateOptions: OptionsProtocol { | |||
| <*> m <| Switch(flag: "f", key: "force", usage: "Whether to overwrite existing playground") | |||
| <*> m <| Switch(key: "no-open", usage: "Whether to open new playground") | |||
| <*> m <| Switch(key: "input", usage: "Whether to enable standard input") | |||
| <*> m <| Switch(key: "no-save", usage: "Remove playground file automatically") | |||
There was a problem hiding this comment.
I prefer to also add shorthand. (But I have no idea....)
There was a problem hiding this comment.
I votes -n (though I know it may cause confusion with --no-save--no-open...)
| @@ -63,6 +71,23 @@ class HandlerTests: XCTestCase { | |||
| XCTAssertTrue(manager.fileExists(atPath: playgroundURL(for: "hello").path)) | |||
| } | |||
|
|
|||
| func testCreateWithTemporaryOption() { | |||
| _ = handler.create("hello", for: .iOS, temporary: true) | |||
There was a problem hiding this comment.
We should use @discardableResult. (I'm goint to add after this.)
|
Thanks 🎉 |
|
Thank you @morishin ❤️ Upgrade Toybox to 0.2.0 with Homebrew to use new feature. $ brew upgrade giginet/toybox/toybox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3
I implemented autoremove feature.
<name>.autoremove.playgroundwith--rmoption..autoremovesuffix are not shown bytoybox listcommand..autoremovesuffix every timetoyboxcommand has been called.Please review it @giginet