Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove automatically anonymous playground file instead of using --no-save option #7

Merged
merged 2 commits into from
May 23, 2017
Merged

Remove automatically anonymous playground file instead of using --no-save option #7

merged 2 commits into from
May 23, 2017

Conversation

morishin
Copy link
Contributor

We create a playground file with no name instead of using --no-save/-n option.
Please review @giginet

@morishin
Remove automatically anonymous playground file
37e5619 
instead of using --no-save option
giginet
giginet approved these changes May 20, 2017
View reviewed changes
Copy link
Owner

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

This change brakes backward compatibility.
So I'll announce and update README.

@morishin
Copy link
Contributor Author

Thanks for your review! Please merge it when you're ready 🙏

@giginet giginet merged commit 6257534 into giginet:master May 23, 2017
@morishin morishin deleted the improve-no-save-feature branch May 23, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giginet giginet giginet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@morishin @giginet