Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DwarfUnit improvements #381

Merged
merged 5 commits into from
Feb 6, 2019
Merged

DwarfUnit improvements #381

merged 5 commits into from
Feb 6, 2019

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Feb 4, 2019

These are the result of converting addr2line to use DwarfUnit.

@philipc
read: change DwarfUnit::name/comp_dir to Option<R>
9dabba0 
This is more convenient in general, and allows changing the
DebugLine::program() parameters back to how they used to be.
@philipc philipc requested a review from fitzgen February 4, 2019 07:36
@coveralls
Copy link

coveralls commented Feb 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 86.536% when pulling 7ea675b on philipc:dwarfunit into 9ed8d7b on gimli-rs:master.

fitzgen
fitzgen approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@philipc philipc merged commit 955c33e into gimli-rs:master Feb 6, 2019
@philipc philipc deleted the dwarfunit branch February 6, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipc @coveralls @fitzgen