Delete phantom Section members #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These complicate the API without providing significant benefit. Deleting these allows consumers to reuse more code between .eh_frame and .debug_frame. The main benefit I could see for these was in the tests, where it ensured that the section type we wrote in the test builder was the same as the section type we tried to read back. We can retain this check by adding a `SectionKind` parameter in the tests, and we can extend this check to handle endianity as well.
fitzgen
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These complicate the API without providing significant benefit. Deleting these allows consumers to reuse more code between .eh_frame and .debug_frame.
The main benefit I could see for these was in the tests, where it ensured that the section type we wrote in the test builder was the same as the section type we tried to read back. We can retain this check by adding a
SectionKindparameter in the tests, and we can extend this check to handle endianity as well.Partial fix for #296