read: improved UnexpectedEof errors #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stores a (hopefully) unique `ReaderOffsetId` in the error, which can be converted back to a section+offset for display.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores a (hopefully) unique
ReaderOffsetIdin the error, which can be converted back to a section+offset for display.This can be expanded to more error variants as needed.
The
ReaderOffsetIdis a little hacky: for slices it is a cast of the pointer to au64, but this is only unique if the slice is backed by its own memory allocation. I think this is good enough though? To do better I think we need to add a unique id field to every base reader (but which is preserved by clones), and I'd prefer not to do that just for this. Users can define their own reader which does this if required.