read: add EntriesRaw
#455
Merged
read: add EntriesRaw
#455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a micro-optimisation that gives about 1% improvement in instruction counts, but the benchmark time difference is lost in the noise.
|
I probably should add a test too... tomorrow. |
fitzgen
approved these changes
Nov 25, 2019
benches/bench.rs
Outdated
| while let Some(attr) = attrs.next().expect("Should parse entry's attribute") { | ||
| test::black_box(&attr); | ||
| loop { | ||
| match attrs.next() { |
There was a problem hiding this comment.
What's the point of going from while let Some to loop + match?
There was a problem hiding this comment.
It avoids a move of the attribute which the compiler fails to optimise away. But maybe this requires more explanation and deserves its own PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a raw reader of Debugging Information Entries. This is useful for users who require performance and don't need the niceties of
EntriesCursor. Comparative benchmarks:(Note: if you run the benchmarks yourself you'll see that
bench_parsing_debug_info_with_endian_rc_sliceis faster; this is due to differences in inlining.)These benchmarks don't do anything with the attributes, so in practical applications the gains aren't this much, but they are still significant (I have tested in addr2line).