-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom storage for UnwindContext and Evaluation #595
Conversation
Once we do use const generics, would |
Wouldn't it require exposing ArrayVec to the user? |
I think we can still do |
Ok, that makes sense. So the comment on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Partially addresses #581 (alloc is still a dep, but everything unwind related doesn't require heap).
New traits
UnwindContextStorage
andEvaluationStorage
is introduced to allow customisation of what the storage is.UnwindContext
,UnwindTable
andEvaluation
will gain 1 additional generic parameter which is defaulted toStoreOnHeap
.The ctor with this generic param is called
new_in
, and the oldnew
method will use the default param so type inference won't fail.