Revert "context: inherits context cancelation and deadline from http.Request context for Go>=1.7 (#1690)" #1736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1736 +/- ##
=========================================
- Coverage 99.4% 99.4% -0.01%
=========================================
Files 42 41 -1
Lines 2029 2023 -6
=========================================
- Hits 2017 2011 -6
Misses 9 9
Partials 3 3
Continue to review full report at Codecov.
|
appleboy
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert #1690
Here #153 (comment) @manucorporat said
gin.Context behave like context.Background + Value, and revert it to fix #1731 first.cc @rbeuque74
@appleboy please help me to review the revert, thanks!