-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(router): add literal colon support (#1432) #2857
Conversation
c1585c2
to
2e6a3ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2857 +/- ##
==========================================
- Coverage 99.21% 99.06% -0.16%
==========================================
Files 42 44 +2
Lines 3182 2772 -410
==========================================
- Hits 3157 2746 -411
+ Misses 17 15 -2
- Partials 8 11 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
464c884
to
ed0a30c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to optimize and adjust, why define some routing rules like \?
The feature included in this PR is not about defining rule like Please refer to issue #1432 for more details |
02a7101
to
6f0bdd0
Compare
9007250
to
0be5dcc
Compare
@daheige Thanks a lot 👍 🙏 ! |
Hi @thinkerou wondering if you can have a look and approve the PR for the next release. Many thanks 🙏 |
I will take it asap. |
@wssccc Can you also add http-router benchmark report since you update the router tree structure? |
12c06d9
to
43830be
Compare
d84488e
to
e5e3228
Compare
@wssccc I mean the different benchmarks between the master and this PR branch. |
See the sample: #1826 (comment) using https://pkg.go.dev/golang.org/x/perf/cmd/benchstat tool to get benchmark result. |
The pull request benchmark data:
The master branch benchmark data:
|
@appleboy done |
Implement literal colon support using the approach described in #1432