This repository has been archived by the owner on Apr 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Gulp release #104
Open
lejoe
wants to merge
13
commits into
master
Choose a base branch
from
gulp-release
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Gulp release #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the steps are 'pseudo code' for now
Asks for the bumpt type creates a new version tags it pushes to github
It is already catched in side the function
We just need the default
}; | ||
|
||
// Makes sure we do this on the master branch | ||
var asserBranchAllowed = function(done) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sp: 'assert'
asserBranchAllowed -> assertBranchAllowed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the release process:
1.1 make sure if we are on master branch
1.2 ask for bump type
1.3 npm version (bump the version on package.json)
1.4 git push & git push --tag
2.1 manually do a pull request on github (master to release)
2.2 merge the pull request
3.1 CI builds & creates a github release
3.2 CI adds the build to the github release
3.3 CI commits the build files to a seperate release-build branch