Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Fedora 31 #46

Merged
merged 1 commit into from
Mar 7, 2020
Merged

Add support for Fedora 31 #46

merged 1 commit into from
Mar 7, 2020

Conversation

jmcfarlane
Copy link
Contributor

No description provided.

giovtorres
giovtorres requested changes Mar 4, 2020
View reviewed changes
Copy link
Owner

@giovtorres giovtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! Couple additional things to add to this PR:

  • Would you mind updating the README?
  • Would you add tests here, similar to how Fedora 30 is tested?

@giovtorres giovtorres added the New OS New Operating System label Mar 4, 2020
@jmcfarlane
Copy link
Contributor Author

No problem, will do 👍

giovtorres
giovtorres approved these changes Mar 7, 2020
View reviewed changes
Copy link
Owner

@giovtorres giovtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for addressing feedback.

@giovtorres giovtorres merged commit 09db542 into giovtorres:master Mar 7, 2020
@jmcfarlane jmcfarlane deleted the fc31 branch December 1, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovtorres giovtorres giovtorres approved these changes

Assignees
No one assigned
Labels
New OS New Operating System
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcfarlane @giovtorres