Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for openSUSE Leap 15.2 #50

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Conversation

meffie
Copy link
Contributor

@meffie meffie commented Mar 26, 2020

Add support for openSUSE using the most recent openSUSE Leap cloud image
provided by the openSUSE build service.

kvm-install-vm Outdated Show resolved Hide resolved
Copy link
Owner

@giovtorres giovtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another contribution, @meffie! Could you add a test case for this and also update the README?

Add support for openSUSE using the most recent openSUSE Leap cloud image
provided by the openSUSE build service.
@meffie
Copy link
Contributor Author

meffie commented Mar 29, 2020

More than happy to add the test case. Sorry for the omission!

I did a force push with the test cases added and the README updated. Please let me know if I missed anything else.

✓ Install VM (openSUSE Leap 15) - batstestvm-opensuse15
✓ Delete VM (openSUSE Leap 15) - batstestvm-opensuse15

Copy link
Owner

@giovtorres giovtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@giovtorres giovtorres merged commit bd9ea9f into giovtorres:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New OS New Operating System
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants