Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian10 #53

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Debian10 #53

merged 2 commits into from
Apr 3, 2020

Conversation

meffie
Copy link
Contributor

@meffie meffie commented Apr 2, 2020

Also update the os-variant for the previously added opensuse15.

debian10)
QCOW=debian-10-openstack-amd64.qcow2
OS_TYPE="linux"
OS_VARIANT="debian10"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: "auto" does not work here. The debian guest requires the os variant in order to setup the kernel options, otherwise the network interface will not be started!

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I had trouble with a previous version of Debian and I didn't figure out why. Probably could have been related to this, or something similar.

@@ -475,7 +484,7 @@ function set_sudo_group ()
centos?|fedora??|*-atomic|amazon?|opensuse* )
SUDOGROUP="wheel"
;;
ubuntu*|debian? )
ubuntu*|debian* )
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -396,7 +405,7 @@ function fetch_images ()
opensuse15)
QCOW=openSUSE-Leap-15.2-OpenStack.x86_64.qcow2
OS_TYPE="linux"
OS_VARIANT="auto"
OS_VARIANT="opensuse15.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sneaking in this change? 😉

Copy link
Owner

@giovtorres giovtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚢 it

@giovtorres giovtorres merged commit 9bf3e00 into giovtorres:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants