-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debian10 #53
Debian10 #53
Conversation
debian10) | ||
QCOW=debian-10-openstack-amd64.qcow2 | ||
OS_TYPE="linux" | ||
OS_VARIANT="debian10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: "auto" does not work here. The debian guest requires the os variant in order to setup the kernel options, otherwise the network interface will not be started!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out. I had trouble with a previous version of Debian and I didn't figure out why. Probably could have been related to this, or something similar.
@@ -475,7 +484,7 @@ function set_sudo_group () | |||
centos?|fedora??|*-atomic|amazon?|opensuse* ) | |||
SUDOGROUP="wheel" | |||
;; | |||
ubuntu*|debian? ) | |||
ubuntu*|debian* ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -396,7 +405,7 @@ function fetch_images () | |||
opensuse15) | |||
QCOW=openSUSE-Leap-15.2-OpenStack.x86_64.qcow2 | |||
OS_TYPE="linux" | |||
OS_VARIANT="auto" | |||
OS_VARIANT="opensuse15.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sneaking in this change? 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🚢 it
Also update the os-variant for the previously added opensuse15.