Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fix for debian10 cloud init issue; #57 #59

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Add fix for debian10 cloud init issue; #57 #59

merged 1 commit into from
Apr 28, 2020

Conversation

berkutta
Copy link
Contributor

As discussed in issue

meffie
meffie reviewed Apr 27, 2020
View reviewed changes
Copy link
Contributor

@meffie meffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my host with debian9 and debian10 and works for me.

Thank you for the fix.

Suggest we remove the stray CI_ISO_DEVICE=cdrom before merging.

kvm-install-vm Show resolved Hide resolved
@berkutta berkutta force-pushed the debian10-cloud-init-issue branch from 9da1a54 to 941a932 Compare April 27, 2020 17:24
meffie
meffie approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@meffie meffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm

giovtorres
giovtorres approved these changes Apr 28, 2020
View reviewed changes
Copy link
Owner

@giovtorres giovtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 This is a great fix! Thank you.

@giovtorres giovtorres merged commit 5d5668d into giovtorres:master Apr 28, 2020
@giovtorres giovtorres mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meffie meffie meffie approved these changes

@giovtorres giovtorres giovtorres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berkutta @meffie @giovtorres