Revert "Rename POPULAR_THRESHOLD to OVERWHELMED_THRESHOLD"

This reverts commit 10ce331.
gip-inclusion · Jan 13, 2025 · 33b7ceb · 33b7ceb
1 parent 10ce331
commit 33b7ceb
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/itou/companies/models.py b/itou/companies/models.py
@@ -567,7 +567,7 @@ def with_annotation_is_popular(self):
         }
         annotation = self.with_job_applications_count(filters=job_apps_filters).annotate(
             is_popular=Case(
-                When(job_applications_count__gte=self.model.OVERWHELMED_THRESHOLD, then=True),
+                When(job_applications_count__gte=self.model.POPULAR_THRESHOLD, then=True),
                 default=False,
                 output_field=BooleanField(),
             )
@@ -604,7 +604,7 @@ class JobDescription(models.Model):
     """
 
     MAX_UI_RANK = 32767
-    OVERWHELMED_THRESHOLD = 20
+    POPULAR_THRESHOLD = 20
     # Max number or workable hours per week in France (Code du Travail)
     MAX_WORKED_HOURS_PER_WEEK = 48
 

diff --git a/itou/templates/companies/includes/_card_jobdescription.html b/itou/templates/companies/includes/_card_jobdescription.html
@@ -40,7 +40,7 @@
                         {% if job_description.is_popular %}
                             <span class="badge badge-sm rounded-pill bg-accent-03 text-primary">
                                 <i class="ri-group-line me-1" aria-hidden="true"></i>
-                                {{ job_description.OVERWHELMED_THRESHOLD }}+<span class="ms-1">candidatures</span>
+                                {{ job_description.POPULAR_THRESHOLD }}+<span class="ms-1">candidatures</span>
                             </span>
                         {% endif %}
                         <ul class="c-box--results__list-contact flex-md-grow-1 mt-1">

diff --git a/itou/templates/companies/includes/_list_siae_actives_jobs_row.html b/itou/templates/companies/includes/_list_siae_actives_jobs_row.html
@@ -17,7 +17,7 @@
         {% if job.is_popular %}
             <span class="badge badge-sm rounded-pill bg-accent-03 text-primary">
                 <i class="ri-group-line me-1" aria-hidden="true"></i>
-                {{ job.OVERWHELMED_THRESHOLD }}+<span class="ms-1">candidatures</span>
+                {{ job.POPULAR_THRESHOLD }}+<span class="ms-1">candidatures</span>
             </span>
         {% endif %}
         <p class="fs-sm mb-0 mt-1">

diff --git a/itou/templates/companies/includes/_siae_jobdescription.html b/itou/templates/companies/includes/_siae_jobdescription.html
@@ -16,7 +16,7 @@
                 {% endif %}
                 {% if job.is_popular %}
                     <div class="order-1 order-md-2">
-                        <span class="badge badge-sm rounded-pill bg-accent-03 text-primary ms-0 ms-lg-2 mt-1 mt-lg-0"><i class="ri-group-line"></i>{{ job.OVERWHELMED_THRESHOLD }}+ candidatures</span>
+                        <span class="badge badge-sm rounded-pill bg-accent-03 text-primary ms-0 ms-lg-2 mt-1 mt-lg-0"><i class="ri-group-line"></i>{{ job.POPULAR_THRESHOLD }}+ candidatures</span>
                     </div>
                 {% endif %}
             </div>

diff --git a/itou/www/search/views.py b/itou/www/search/views.py
@@ -268,7 +268,7 @@ def get_results_page_and_counts(self, siaes, job_descriptions):
         )
         for job_description in page.object_list:
             job_description.is_popular = (
-                len(job_description.jobapplication_set_pending) >= job_description._meta.model.OVERWHELMED_THRESHOLD
+                len(job_description.jobapplication_set_pending) >= job_description._meta.model.POPULAR_THRESHOLD
             )
         return PageAndCounts(
             results_page=page,

diff --git a/tests/companies/test_models.py b/tests/companies/test_models.py
@@ -358,7 +358,7 @@ def test_with_annotation_is_popular(self):
 
         # Test popular threshold: popular job description
         popular_job_description = siae_job_descriptions[0]
-        for _ in range(JobDescription.OVERWHELMED_THRESHOLD + 1):
+        for _ in range(JobDescription.POPULAR_THRESHOLD + 1):
             JobApplicationFactory(to_company=company, selected_jobs=[popular_job_description], job_seeker=job_seeker)
 
         assert JobDescription.objects.with_annotation_is_popular().get(pk=popular_job_description.pk).is_popular
@@ -372,7 +372,7 @@ def test_with_annotation_is_popular(self):
         # Popular job descriptions count related **pending** job applications.
         # They should ignore other states.
         job_description = siae_job_descriptions[2]
-        threshold_exceeded = JobDescription.OVERWHELMED_THRESHOLD + 1
+        threshold_exceeded = JobDescription.POPULAR_THRESHOLD + 1
 
         JobApplicationFactory.create_batch(
             threshold_exceeded,