Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Le badge 20+ candidatures sur les résultats de recherche ne doit pas inclure de candidatures archivées #5378

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

dejafait
Copy link
Contributor

@dejafait dejafait commented Jan 13, 2025

https://www.notion.so/plateforme-inclusion/Le-badge-20-candidature-sur-les-r-sultats-de-recherche-ne-doit-pas-inclure-de-candidatures-archiv-e-177e8fa5c35b80e49344f093e58cf484

🤔 Pourquoi ?

Les candidatures archivées (trop anciennes) ne doivent pas être comptées pour l’affichage du badge 20+ candidatures car :

  • il risque de ne jamais disparaître car ces veille candidatures ne seront jamais traitées
  • il ne reflète pas l’état actuel du recrutement
  • trop nombreux donc perd son impact

🌈 Et un petit bonus technique en passant

  • Je renomme popular en overwhelmed qui est plus pertinent car l'état en question est en fait indésirable.

@dejafait dejafait self-assigned this Jan 13, 2025
@dejafait dejafait marked this pull request as draft January 13, 2025 13:53
@dejafait dejafait force-pushed the dejafait/fix_annotation_is_popular branch from ead2a31 to 5538caa Compare January 13, 2025 14:24
@dejafait dejafait marked this pull request as ready for review January 13, 2025 14:40
@dejafait dejafait requested a review from leo-naeka January 13, 2025 14:40
@dejafait dejafait changed the title Le badge 20+ candidature sur les résultats de recherche ne doit pas inclure de candidatures archivées Le badge 20+ candidatures sur les résultats de recherche ne doit pas inclure de candidatures archivées Jan 13, 2025
itou/templates/apply/submit/application/jobs.html Outdated Show resolved Hide resolved
tests/companies/test_models.py Outdated Show resolved Hide resolved
tests/companies/test_models.py Outdated Show resolved Hide resolved
@tonial
Copy link
Contributor

tonial commented Jan 14, 2025

C'est beaucoup plus logique avec ton renommage :)

Copy link
Contributor

@leo-naeka leo-naeka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mêmes remarques qu'Antoine, à part cela tout bon 👌

@dejafait dejafait force-pushed the dejafait/fix_annotation_is_popular branch from 5538caa to 278ab51 Compare January 20, 2025 14:35
@dejafait dejafait requested review from tonial and leo-naeka January 20, 2025 16:53
Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dejafait dejafait added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit ca12f9b Jan 23, 2025
9 checks passed
@dejafait dejafait deleted the dejafait/fix_annotation_is_popular branch January 23, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants