Merge pull request Skyscanner#2313 from Skyscanner/KOA-4854

[KOA-4854] Fix height in buttons with icon
giriawu · Dec 17, 2021 · 1c513e3 · 1c513e3
2 parents 293a27e + b20cfad
commit 1c513e3
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/...s__/storyshots-test-js-visual-tests-bpk-component-button-visual-test-1-snap.png b/...s__/storyshots-test-js-visual-tests-bpk-component-button-visual-test-1-snap.png
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -6,7 +6,10 @@
 - bpk-component-calendar:
 - bpk-component-datepicker:
 - bpk-component-scrollable-calendar:
-    - Updated sizing of calendar component to correct width and spacing
+  - Updated sizing of calendar component to correct width and spacing
+
+- bpk-component-button:
+  - Fixed height in buttons with icon
 
 **Added:**
 
@@ -15,4 +18,4 @@
 
 - bpk-mixins:
     - Moved `margin-top` from `bpk-component-fieldset` to `bpk-component-form-validation` to ensure that the `8px` margin is applied to the top of the form validation.
-    - Updated sizing of calendar component to correct width and spacing
+    - Updated sizing of calendar component to correct width and spacing
diff --git a/packages/bpk-component-button/src/BpkButtonBase.module.css b/packages/bpk-component-button/src/BpkButtonBase.module.css
diff --git a/packages/bpk-component-button/src/BpkButtonBase.module.scss b/packages/bpk-component-button/src/BpkButtonBase.module.scss
@@ -40,6 +40,7 @@
   }
 
   svg {
+    display: block;
     fill: currentColor;
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -40,6 +40,7 @@ @@
       }
       svg {
+        display: block;
         fill: currentColor;
       }
     }