Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 9.5: Access control #2092 #2153

Merged
2 commits merged into from
Sep 23, 2021
Merged

Java 9.5: Access control #2092 #2153

2 commits merged into from
Sep 23, 2021

Conversation

Sneha-0308
Copy link
Contributor

@Sneha-0308 Sneha-0308 commented Sep 23, 2021 •
edited
Loading

Description 📜

Done Audio Explaining the Access control #2092

Type of change 📝

  • Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)

Domain of Contribution 📊

  • Java_#Domain

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GWOC'21 contributor

@keywordlabeler keywordlabeler bot added the Audio Audio Format label Sep 23, 2021
@Sneha-0308
Copy link
Contributor Author

Sneha-0308 commented Sep 23, 2021 •
edited
Loading

Access control #2092 : Adding Access control audio in .mp3 format

@AkMo3 AkMo3 added Java Review_Ongoing Denotes that review is ongoing and it is not to be merged. labels Sep 23, 2021
sumitaccess007
sumitaccess007 reviewed Sep 23, 2021
View reviewed changes
Copy link
Contributor

@sumitaccess007 sumitaccess007 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR - #2153, is okay to proceed with. 👌
All the Access Controls are covered and explained.

Good Work @Sneha-0308, Keep Learning, Keep Improving.

++ @garvitraj @AkMo3

@ghost ghost merged commit 359afc9 into girlscript:Java Sep 23, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumitaccess007 sumitaccess007 sumitaccess007 left review comments

Assignees
No one assigned
Labels
Audio Audio Format Java Review_Ongoing Denotes that review is ongoing and it is not to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sneha-0308 @sumitaccess007 @AkMo3