Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iam sakshi patch 1 #8559

Open
wants to merge 31 commits into
base: Competitive_Programming
Choose a base branch
from
Open

Iam sakshi patch 1 #8559

wants to merge 31 commits into from

Conversation

iam-sakshi
Copy link
Contributor

Description 📜

Solve problem Reverse Word in string with different approaches.

Reverse Word in string #8512

Type of change 📝

  • Au#dio (Should be in mp3 format Includes speech clarity, Concise ,Low distortion)
  • Vi#deo (Animations, screen-recordings, presentations and regular explanatory films are all possibilties etc)
  • Doc#umentation (Content Creation in the form of codes or tutorials)
  • Other (If you choose other, Please mention changes below)

Domain of Contribution 📊

  • Android Dev #(Flutter)
  • Android Dev #(Java)
  • Android Dev #(Kotlin)
  • Backend Dev #(Java)
  • Backend Dev #(.NET)
  • Backend Dev #(PHP)
  • Backend Dev #(Python)
  • C/#CPP
  • Competitive #Programming
  • Cyber #Security
  • DS#A
  • Data#base
  • Datascience with #Python
  • Datascience with #R
  • Frontend Dev #HTML/CSS/JS
  • Frontend Dev #React/Angular/Vue
  • Go#lang
  • Interview #Prep
  • Java_#Domain
  • JavaScript_#Domain
  • ME#RN
  • Machine #Learning
  • Open #Source
  • Python_#Domain
  • Ru#st
  • Statis#tics
  • UI/#UX

Checklist ✅

  • I follow Contributing Guidelines & Code of conduct of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I'm GWOC'21 contributor

Screenshots / Gif (Optional) 📸

iam-sakshi and others added 28 commits November 6, 2021 13:54
@iam-sakshi
Create Binary Search Applications
d4e4a6d 
Added Documentation regarding the Simple Applications of Binary Search
@iam-sakshi
Rename Binary Search Applications to Binary Search Application.mds
3580307
@iam-sakshi
Rename Binary Search Application.mds to Binary Search Application.md
c722bba
@iam-sakshi
Update Binary Search Application.md
fa668b4 
All the suggested changes are done .
@iam-sakshi
Rename Binary Search Application.md to BinarySearchApplication.md
ebbdf30 
renamed
@iam-sakshi @ravireddy07
Update Competitive_Programming/C++/Searching & Sorting/Binary Search/…
d6a5ccc 
…BinarySearchApplication.md

Co-authored-by: Ravi Kanth Gojur <[email protected]>
@iam-sakshi @ravireddy07
Update Competitive_Programming/C++/Searching & Sorting/Binary Search/…
27eb296 
…BinarySearchApplication.md

Co-authored-by: Ravi Kanth Gojur <[email protected]>
@iam-sakshi
Create BinarySearchApplication.md
0a25003 
Done all the required changes suggested.
@iam-sakshi
Update BinarySearchApplication.md
44c4d25 
done changes
@iam-sakshi
Create EuclidAlgorithm.md
46b5ca0 
This include the brute force and Euclid way to find GCD
@iam-sakshi
Merge branch 'girlscript:Competitive_Programming' into Competitive_Pr…
4e1210c 
…ogramming
@iam-sakshi
Create heap.md
28bddfe
@iam-sakshi
Merge pull request #1 from iam-sakshi/cp-1
13c35f3 
heap.md
@iam-sakshi
Delete heap.md
4bbc08c
@iam-sakshi
Create heap.md
2a994e0
@iam-sakshi
Merge pull request #3 from iam-sakshi/cp-1
bae0754 
Create heap.md
@iam-sakshi
Delete heap.md
37c0569
@iam-sakshi
Create TopKthFrequentElement.md
418530e
@iam-sakshi
Merge pull request #4 from iam-sakshi/cp
c1e905c 
Create TopKthFrequentElement.md
@iam-sakshi
Delete TopKthFrequentElement.md
d67be13
@iam-sakshi
Update EuclidAlgorithm.md
9e2e4ab
@iam-sakshi
Update EuclidAlgorithm.md
2d9c394
@iam-sakshi
Create ReverseWordInAString.md
638de22
@iam-sakshi
Merge pull request #5 from iam-sakshi/CP_1
abfa9fa 
Create ReverseWordInAString.md
@iam-sakshi
Delete ReverseWordInAString.md
190919b
@iam-sakshi
Merge branch 'girlscript:Competitive_Programming' into Competitive_Pr…
5da4b33 
…ogramming
@iam-sakshi
Create ReverseWordInAString.md
b1ce60d
@iam-sakshi
Delete EuclidAlgorithm.md
9a94108
@iam-sakshi
Copy link
Contributor Author

@ravireddy07 please check, I have tried updating the branch but still all the commits are visible , please review the content .

@ravireddy07
Copy link
Contributor

ravireddy07 commented Nov 27, 2021 •
edited
Loading

Which branch you're updating...? @iam-sakshi

@iam-sakshi
Copy link
Contributor Author

I have tried updating all the branches
@ravireddy07

@iam-sakshi @priyankapiba
@Jinal4502 @ErzaTitania-2001
Competitive programming (#9)
c872926 
* Create  ReverseWordInAString.md (#6)

* Competitive programming (#8)

* Merge two arrays according to constraints added.

* Create MagicNumber.md

* Rename MagicNumber.md to NthMagicNumber.md

* header file and heading added.

* Rename Competitive_Programming/Python/Maths & Number Theory/MagicNumber/NthMagicNumber.md to Competitive_Programming/Python/Maths & Number Theory/NthMagicNumber/NthMagicNumber.md

Co-authored-by: BootLook <[email protected]>
Co-authored-by: Jinal4502 <[email protected]>
Co-authored-by: Ahana Pal <[email protected]>

Co-authored-by: BootLook <[email protected]>
Co-authored-by: Jinal4502 <[email protected]>
Co-authored-by: Ahana Pal <[email protected]>
@iam-sakshi
Copy link
Contributor Author

I have updated , please review it now @ravireddy07

@iam-sakshi
Copy link
Contributor Author

please review now , There is only one file changed , you can check now. @ravireddy07

@ravireddy07
Copy link
Contributor

please review now , There is only one file changed , you can check now. @ravireddy07

The point here is not to have the commits which already merged.
Just update your branch with current CP branch. That will solve.

Just checkout to cp and pull upstream changes and checkout to iam-sakshi-patch-1 and merge it.

@ravireddy07
Copy link
Contributor

Please follow this steps: @iam-sakshi

  1. fork the original repo.
  2. clone your fork in your local.
  3. add upstream/reference to original-repo.
  4. switch to your domain-branch from main.
  5. create a new branch on your domain-branch like contribution-1
  6. start working on issues, add and commit your changes.
  7. now, to resolve or get rid of conflicts: switch to your domain-branch and pull the latest code of your domain-branch.
  8. after pulling, switch to your branch contribution-1 and run git merge domain-branch
  9. If there are any conflicts, resolve them and commit.
  10. now push your changes to contribution-1 branch and make a PR pointing to your domain-branch.

@gauravdas014
Copy link
Collaborator

@ravireddy07 is this a valid PR?

@ravireddy07
Copy link
Contributor

Yes @gauravdas014, It's valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
GWOC21
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iam-sakshi @ravireddy07 @gauravdas014