Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GB3-753: add docker-compose file for deployment #10

Merged
merged 2 commits into from
Jan 14, 2025
Merged

GB3-753: add docker-compose file for deployment #10

merged 2 commits into from
Jan 14, 2025

Conversation

trffrm
Copy link
Contributor

@trffrm trffrm commented Jan 9, 2025

No description provided.

@trffrm trffrm requested a review from TIL-EBP January 9, 2025 15:09
wendlans
wendlans approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@wendlans wendlans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me 👌
One minor thing: you could mention the compose file in the README

wendlans
wendlans approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@wendlans wendlans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good now! Thanks for updating the README

@trffrm trffrm merged commit ec11bc5 into develop Jan 14, 2025
1 check passed
@trffrm trffrm deleted the feature/gb3-753-deployment-pipeline branch January 14, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendlans wendlans wendlans approved these changes

@TIL-EBP TIL-EBP Awaiting requested review from TIL-EBP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trffrm @wendlans