Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve BigDiffTest #483

Closed
Marcono1234 opened this issue May 13, 2020 · 2 comments · Fixed by #723
Closed

Improve BigDiffTest #483

Marcono1234 opened this issue May 13, 2020 · 2 comments · Fixed by #723
Milestone

Comments

@Marcono1234
Copy link
Contributor

Marcono1234 commented May 13, 2020

BigDiffTest takes compared to all other tests a rather long time, for me it needs about 4 minutes.
Apparently most of that time comes from writing 100000 (!) files. Could you please check if there are other ways to implement this test?

Long build / testing times make it less attractive for people to run the tests, which could decrease code quality. Additionally writing that many files puts in my opinion an unjustified amount of work on the file system.

@TheSnoozer TheSnoozer added this to the 7.0.1 milestone Feb 9, 2024
@TheSnoozer
Copy link
Collaborator

Please make a PR with concrete suggestions.

@Marcono1234
Copy link
Contributor Author

Marcono1234 commented Feb 9, 2024

@TheSnoozer, my suggestion would be to remove / disable the test (or if really necessary, at least only run it on CI)1. I know this is not a great solution, but in my opinion creating 100.000 files is out of proportion to what this test is covering.

Take a look for example at the recent GitHub "Run basic test with Java" workflow runs: The "Build with Maven" step takes ~1 minute, and of that BigDiffTest takes ~35 seconds. That is more than 50% of the complete Maven build taken just by that one test.

But in the end it is of course your decision. If you think this is justified, then just keep it as it is.

Footnotes

  1. Another alternative would be reducing the number of created files. But this would still cause a lot of work for your drive, and might not even trigger the situation anymore where the Git process produces enough console output to cause a deadlock, defeating the purpose of the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants