Delete BigDiffTest
#723
Merged
Delete BigDiffTest
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was originally added to make sure the `git` process does not hang in case it writes a lot of output to the output streams. To check this behavior, the test created 100.000 (!) files each a few KBs large and then invoked the plugin, hoping that `git` would produce enough output. However, this puts a lot of pressure on the file system and disk due to the large number of files. For GitHub CI whose runners are probably using SSDs, this test alone took more than 50% of the time of the complete Maven build. And when running the test with an HDD the test could easily take minutes. git-commit-id/git-commit-id-plugin-core#101 has added a dedicated and more reliable test which makes sure that the process output is properly consumed, so there is probably no need for this `BigDiffTest` anymore, especially due to the downsides mentioned above.
|
Mhh, ok why not. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Resolves #483
This test was originally added to make sure the
gitprocess does not hang in case it writes a lot of output to the output streams.To check this behavior, the test created 100.000 (!) files each a few KBs large and then invoked the plugin, hoping that
gitwould produce enough output.However, this puts a lot of pressure on the file system and disk due to the large number of files. For GitHub CI whose runners are probably using SSDs, this test alone took more than 50% of the time of the complete Maven build. And when running the test with an HDD the test could easily take minutes.
git-commit-id/git-commit-id-plugin-core#101 has added a dedicated and more reliable test which makes sure that the process output is properly consumed, so there is probably no need for this
BigDiffTestanymore, especially due to the downsides mentioned above.Contributor Checklist
mvn clean packagecheckstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B