Drop Git Credential Manager for Windows #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For quite a while now this project is inactive, and has been archived and been superseded by Git Credential Manager Core. Let's drop Git Credential Manager for Windows, starting by no longer offering that option in the installer. Signed-off-by: Johannes Schindelin <[email protected]>
This affects the code path where we infer settings from reading the system config. Signed-off-by: Johannes Schindelin <[email protected]>
Git Credential Manager for Windows is no longer maintained (being superseded by Git Credential Manager Core), and we just removed the option from the installer. Let's stop including the files altogether. Signed-off-by: Johannes Schindelin <[email protected]>
Git Credential Manager for Windows was superseded by Git Credential Core for a long time now. Signed-off-by: Johannes Schindelin <[email protected]>
Continuing to remove it throughout Git for Windows. Signed-off-by: Johannes Schindelin <[email protected]>
…for Windows This project was superseded by Git Credential Manager Core, and is no longer maintained. Signed-off-by: Johannes Schindelin <[email protected]>
This is the final nail... farewell Git Credential Manager for Windows, you served us well, and now Git Credential Manager Core serves us even better! Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
mjcheetham
approved these changes
Sep 3, 2021
rimrul
reviewed
Sep 3, 2021
dscho
added a commit
that referenced
this pull request
Sep 8, 2021
[Git Credential Manager for Windows](https://github.com/microsoft/Git-Credential-Manager-for-Windows) (which was superseded by [Git Credential Manager Core](https://aka.ms/gcmcore), and was deprecated for a long time now, and no longer succeeds to authenticate with GitHub) is [no longer included in Git for Windows](#377). Signed-off-by: Johannes Schindelin <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a change to drop Git Credential Manager!
Git for Windows ships with two different versions of Git Credential Manager:
Git Credential Manager for Windows
This has been the original (and in the beginning, the only) version of Git Credential Manager.
It was borne out of the need for something more stable, more robust, more actively-developed than
git-credential-wincred, to allow e.g. for Two-Factor-Authentication support. It is based on .NET Framework and hence limited to supporting Windows, and Windows only.It is no longer actively maintained.
Git Credential Manager Core
This version supersedes the first, tries to accomplish the same on Windows, but targets .NET Core, i.e. supports multiple platforms. In particular, it supports macOS and Linux.
It is maintained actively.
Since the first version is no longer maintained, GitHub stopped accepting password-based authentication. In other words, Git Credential Manager for Windows is now obsolete, it does not even manage to allow logging into GitHub.
Therefore, it is high time to just drop the first version, and henceforth only support and include Git Credential Manager Core.