-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post official Docker Image #1163
Comments
@computeronix is this something that needs to be done by the core team, or can anyone do it? I see you seem to have the bits already setup, I'm just wondering what gaps there are... |
Anyone can create a repo but to create an official repo and get that presence the following would need to happen.
…-create free docker account (https://cloud.docker.com)
-setup organization on docker
-invite xxx members to org whom can manage
-publish to store (https://store.docker.com and click publish)
As far as I am aware it's all free to do the above.
Sample official store: https://store.docker.com/images/gitlab-community-edition?tab=description
Plenty of other sample official images in the store.
From there, just add a dockerfile to a location in the official git for Windows repo
(The dockerfile I have has a static version but can easily be changed with powershell to pull a version dynamically depending on requirements).
For the user community then they can reference the official image and build off of it for their own container or they could look at the dockerfiles and utilize the code to further expand their own build image.
I think that's everything :). Let me know if you have any questions
Thank you,
Bill
Sent from my iPhone
On May 12, 2017, at 1:12 AM, Brendan Forster <[email protected]<mailto:[email protected]>> wrote:
@computeronix<https://github.com/computeronix> is this something that needs to be done by the core team, or can anyone do it? I see you seem to have the bits already setup, I'm just wondering what gaps there are...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1163 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ASR7rm8ZreBQb9ugje3Oho9y4f3fB21kks5r4-pTgaJpZM4NY2J2>.
|
@computeronix and what's the use case for Git being on the store for consumers? Are people building Git things into their Docker images? |
Correct and here are a couple examples
Looks like a couple cases open around containers:
https://github.com/git-for-windows/git/issues?utf8=✓&q=is%3Aissue%20is%3Aopen%20docker
Also an example of using fit within windows container
https://github.com/Storj/storjshare-daemon/blob/master/dockerfiles/storjshare-daemon-win.dockerfile
Again these are Windows examples since this is git for Windows :). But same concepts in Linux too.
Also as a note if someone asks about a Windows Container (new within Windows 10 Professional and higher and Server 2016) it's really running on docker in the backend and managed with the same commands.
|
FYI updated the code to automatically retrieve the latest git for windows release when you build a docker with mingit |
Thank you! Contrary to common belief, Git for Windows does not have a large team running it, it relies very much on volunteers such as yourself. And often, innocuous feature requests turn out to place a rather large burden on me, the maintainer, as they never stop with simply implementing one thing and be done with it. In this instance, I would like to point you to this ticket: #1007 As you see, it is very relevant to your feature request: if I put in the effort of publishing the Docker image you requested, and put in even more effort to automate the process so that it is properly updated every time a new Git for Windows version is released, you will probably agree that the problem with volume mapping becomes a much larger problem, as all of a sudden the Docker image would get a more "official" blessing, and every user would expect me to fix the bugs... Therefore my preference would be to keep the setup as-is, possibly changing my release script to send an automated notification to you, if that helps you. |
I'll close this until the time when Git for Windows has enough contributors to do this. It's easy to reopen the ticket then. |
Feature Request:
Post an official docker image for Windows nano and core on the docker store
Here is the docker build files and a sample here
Store Sample:
https://store.docker.com/community/images/computeronix/mingit
Git Hub Dockerfiles:
https://github.com/computeronix/docker-mingit
Again just samples for reference
The text was updated successfully, but these errors were encountered: