Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post official Docker Image #1163

Closed
computeronix opened this issue May 12, 2017 · 7 comments
Closed

Post official Docker Image #1163

computeronix opened this issue May 12, 2017 · 7 comments

Comments

@computeronix
Copy link

Feature Request:
Post an official docker image for Windows nano and core on the docker store
Here is the docker build files and a sample here
Store Sample:
https://store.docker.com/community/images/computeronix/mingit

Git Hub Dockerfiles:
https://github.com/computeronix/docker-mingit

Again just samples for reference

@shiftkey
Copy link

@computeronix is this something that needs to be done by the core team, or can anyone do it? I see you seem to have the bits already setup, I'm just wondering what gaps there are...

@computeronix
Copy link
Author

computeronix commented May 12, 2017 via email

@shiftkey
Copy link

@computeronix and what's the use case for Git being on the store for consumers? Are people building Git things into their Docker images?

@computeronix
Copy link
Author

computeronix commented May 12, 2017 via email

@computeronix
Copy link
Author

computeronix commented May 14, 2017

FYI updated the code to automatically retrieve the latest git for windows release when you build a docker with mingit

https://github.com/computeronix/docker-mingit

@dscho
Copy link
Member

dscho commented May 15, 2017

Thank you!

Contrary to common belief, Git for Windows does not have a large team running it, it relies very much on volunteers such as yourself.

And often, innocuous feature requests turn out to place a rather large burden on me, the maintainer, as they never stop with simply implementing one thing and be done with it.

In this instance, I would like to point you to this ticket: #1007

As you see, it is very relevant to your feature request: if I put in the effort of publishing the Docker image you requested, and put in even more effort to automate the process so that it is properly updated every time a new Git for Windows version is released, you will probably agree that the problem with volume mapping becomes a much larger problem, as all of a sudden the Docker image would get a more "official" blessing, and every user would expect me to fix the bugs...

Therefore my preference would be to keep the setup as-is, possibly changing my release script to send an automated notification to you, if that helps you.

@dscho
Copy link
Member

dscho commented Jun 21, 2017

I'll close this until the time when Git for Windows has enough contributors to do this. It's easy to reopen the ticket then.

@dscho dscho closed this as completed Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants