mingw: avoid fallback for {local,gm}time_r() #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingw-w64's pthread_unistd.h had a bug that mistakenly (because there is no support for the *lockfile() functions required[1]) defined _POSIX_THREAD_SAFE_FUNCTIONS and that was being worked around since 3ecd153 (compat/mingw: support MSys2-based MinGW build, 2016-01-14). the bug was fixed in winphtreads, but as a sideeffect, leaves the reentrant functions from time.h not longer visible and therefore breaks the build. since the intention all along was to avoid using the fallback functions, formalize the use of POSIX by setting the corresponding feature flag and to make the intention clearer compile out the fallback functions. [1] https://unix.org/whitepapers/reentrant.html Signed-off-by: Carlo Marcelo Arenas Belón <[email protected]>
dscho
reviewed
Aug 30, 2021
| #if defined(__sun__) | ||
| #ifdef __MINGW64__ | ||
| #define _POSIX_C_SOURCE 1 | ||
| #elif defined(__sun__) |
There was a problem hiding this comment.
Would this break compiling Git with older mingw-w64? I ask because I have to do precisely that sometimes, e.g. when building MinGit backports.
There was a problem hiding this comment.
no; I obviously tested this change is safe both with the old (from SDK 1.0.8 as released) and new (currently updated) mingw-w64 headers and forgot to mention it.
I am doing an additional test with SDK 1.0.7 (even older releases won't install because of bintray or key issues), but I would be surprised that it wouldn't work.
|
Thank you @carenas! |
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 31, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 31, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 31, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Aug 31, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 31, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 31, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Aug 31, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 1, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 2, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 2, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 2, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 2, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 3, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 3, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Sep 6, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Sep 6, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 8, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 8, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Sep 8, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Sep 8, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Sep 9, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Sep 9, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Sep 9, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Sep 9, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 22, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 23, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Nov 23, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 23, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 23, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 23, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 23, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 24, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 24, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 24, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 24, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Nov 25, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Nov 25, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 27, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 27, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 27, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 27, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 30, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Nov 30, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Dec 3, 2021
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Dec 15, 2021
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Jan 12, 2022
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 12, 2022
mingw: avoid fallback for {local,gm}time_r()
git-for-windows-ci
pushed a commit
that referenced
this pull request
Jan 14, 2022
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Jan 16, 2022
mingw: avoid fallback for {local,gm}time_r()
dscho
added a commit
that referenced
this pull request
Jan 20, 2022
mingw: avoid fallback for {local,gm}time_r()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mingw-w64's pthread_unistd.h had a bug that mistakenly (because there is
no support for the *lockfile() functions required[1]) defined
_POSIX_THREAD_SAFE_FUNCTIONS and that was being worked around since
3ecd153 (compat/mingw: support MSys2-based MinGW build, 2016-01-14).
the bug was fixed in winphtreads, but as a sideeffect, leaves the
reentrant functions from time.h not longer visible and therefore breaks
the build.
since the intention all along was to avoid using the fallback functions,
formalize the use of POSIX by setting the corresponding feature flag and
to make the intention clearer compile out the fallback functions.
[1] https://unix.org/whitepapers/reentrant.html
Signed-off-by: Carlo Marcelo Arenas Belón [email protected]
Thanks for taking the time to contribute to Git!
Those seeking to contribute to the Git for Windows fork should see
http://gitforwindows.org/#contribute on how to contribute Windows specific
enhancements.
If your contribution is for the core Git functions and documentation
please be aware that the Git community does not use the github.com issues
or pull request mechanism for their contributions.
Instead, we use the Git mailing list ([email protected]) for code and
documentation submissions, code reviews, and bug reports. The
mailing list is plain text only (anything with HTML is sent directly
to the spam folder).
Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.
Please read the "guidelines for contributing" linked above!