FSMonitor: deepening a directory causes confusing events #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhostetler
force-pushed
the
try-v4-fsmonitor-part5
branch
from
dbc19ff to
87ec897
Compare
dscho
approved these changes
Oct 11, 2021
|
I suppose I should make it a proper "fixup!" commit. Let me give that a try. |
derrickstolee
approved these changes
Oct 11, 2021
jeffhostetler
force-pushed
the
try-v4-fsmonitor-part5
branch
2 times, most recently
from
78ffc22 to
a7b7c45
Compare
|
This fails on Windows because we do not get trailing slashes on events and cannot tell whether a path is a file or directory in the daemon callback. So the code in the client that marks everything in the cone needs to be revisited. |
Signed-off-by: Jeff Hostetler <[email protected]>
jeffhostetler
force-pushed
the
try-v4-fsmonitor-part5
branch
from
a7b7c45 to
5be8f5c
Compare
dscho
reviewed
Oct 12, 2021
dscho
reviewed
Oct 12, 2021
jeffhostetler
force-pushed
the
try-v4-fsmonitor-part5
branch
from
5be8f5c to
2a5a011
Compare
derrickstolee
approved these changes
Oct 12, 2021
jeffhostetler
force-pushed
the
try-v4-fsmonitor-part5
branch
2 times, most recently
from
a89e24f to
ee44d7d
Compare
|
I am still seeing this: (The same failure happens in the Now, the biggest complication is: Git v2.33.1 was released yesterday, without much in the way of warning (at least that I was aware of). I had hoped to stabilize FSMonitor in Git for Windows before the next Git for Windows release... |
Dhartsell1
approved these changes
Oct 13, 2021
|
WRT the test failures, yeah, I'm still tinkering with the tests. It's in the untracked-cache and not the fsmonitor code, so perhaps I've accidentally created a test for the untracked-cache on Windows. I'm going to take another look at this, but might just decide to split the code and close the fsmonitor-related stuff here and create another issue/pr to look at the untracked-cache. |
jeffhostetler
force-pushed
the
try-v4-fsmonitor-part5
branch
from
ee44d7d to
6193af1
Compare
Signed-off-by: Jeff Hostetler <[email protected]>
Create unit tests to move a directory. Verify that `git status` gives the same result with and without FSMonitor enabled. NEEDSWORK: This test exposes a bug in the untracked-cache on Windows when FSMonitor is disabled. These are commented out for the moment. Signed-off-by: Jeff Hostetler <[email protected]>
jeffhostetler
force-pushed
the
try-v4-fsmonitor-part5
branch
from
6193af1 to
4c3206e
Compare
|
Yay, the build succeeded!!! I'll only wait for a moment until the current snapshot has been built, and then merge this. |
dscho
added a commit
that referenced
this pull request
Feb 15, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 15, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 15, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 15, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 17, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 17, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 21, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 21, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 22, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 22, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 22, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 24, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Feb 24, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 1, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 1, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 2, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 7, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 9, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 9, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 10, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 14, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 15, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 15, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 17, 2022
FSMonitor: deepening a directory causes confusing events
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 22, 2022
FSMonitor: deepening a directory causes confusing events
git-for-windows-ci
pushed a commit
that referenced
this pull request
Mar 23, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Mar 30, 2022
FSMonitor: deepening a directory causes confusing events
dscho
added a commit
that referenced
this pull request
Apr 4, 2022
FSMonitor: deepening a directory causes confusing events
derrickstolee
pushed a commit
to microsoft/git
that referenced
this pull request
Apr 12, 2022
…onitor-part5 FSMonitor: deepening a directory causes confusing events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a directory can cause confusion. Items immediately within the directory are invalidated and re-scanned, but deeper items are not. This causes stale/confusing status to be reported.