-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shapes for a front-end usage #137
Comments
Hi @spamforhope , Those 2 global vars are meant to be unreachable by web clients as the libraries should be included using the standard approach of The var gObjPptxMasters = {
TITLE_SLIDE: {
[...] What front end are you using? |
I had the same problem. I used Vue. For the time being, I comment out this if statement. |
Thanks for bringing this up. This could stand to be improved. Re-opening so these vars can be declared in our newer node and angular/react detection methods. |
Hi All, The newest code just checked in should resolve this issue, making the Colors and Shapes libraries available to front-end applications. Appreciate everyone's feedback! |
You have unreachable code for a front-end usage of this module:
if ( NODEJS ) { var gObjPptxMasters = require('../dist/pptxgen.masters.js'); var gObjPptxShapes = require('../dist/pptxgen.shapes.js'); }
So if we don't use NodeJS to generate PPT we cannot use all possible shapes (for ex. shapes.OVAL, etc.)
I've fixed this by comment out this IF statement in your code, but it's bad behaviour
The text was updated successfully, but these errors were encountered: