Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise Dependency - TypeError: Promise.all is not a function #188

Closed
bartolomeu opened this issue Sep 15, 2017 · 1 comment
Closed

Promise Dependency - TypeError: Promise.all is not a function #188

bartolomeu opened this issue Sep 15, 2017 · 1 comment
Assignees
Milestone

Comments

@bartolomeu
Copy link

bartolomeu commented Sep 15, 2017

When I use pptx.save() throws

TypeError: Promise.all is not a function

That's caused by this call in the dist/pptxgen.js:1522
Promise.all( arrChartPromises )

in the file bower.json:10 there is the dependency of promise:
"promise": "^0.2.2"

PromiseJS doesn't have implemented all()

The main question is Promise is implemented by ECMAScript 2015 (6th Edition, ECMA-262) according with MSN

Chrome - 32.0
Edge - (Yes)
Firefox - 29.0
Internet Explorer - No
Opera - 19
Safari - 7.1

Just removing the dependency of promise will make the the browser use the native Promise from ECMA and finish this problem, that I belive only occours installing through bower.

@bartolomeu bartolomeu changed the title Promise Dependency Promise Dependency - TypeError: Promise.all is not a function Sep 15, 2017
gitbrent pushed a commit that referenced this issue Sep 15, 2017
@gitbrent gitbrent self-assigned this Sep 15, 2017
@gitbrent
Copy link
Owner

Hi @bartolomeu ,

Thanks for letting me know about this. As you pointed out the only reason to have the polyfill is for IE11, everyone else has it.

Therefore, i've just removed that dependency altogether. We'll be dropping IE11 support soon anyway, so hopefully there are not many users impacted.

@gitbrent gitbrent added this to the 1.9.0 milestone Sep 15, 2017
gitbrent pushed a commit that referenced this issue Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants