Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlink creates malformed slide if it includes & #562

Closed
Tehnix opened this issue Jun 14, 2019 · 1 comment
Closed

Hyperlink creates malformed slide if it includes & #562

Tehnix opened this issue Jun 14, 2019 · 1 comment
Assignees
Milestone

Comments

@Tehnix
Copy link

Tehnix commented Jun 14, 2019

This is in relation to the true issue of #90. Including relevant information here:

Reproduction case:

var pptx = new PptxGenJS();
var slide = pptx.addNewSlide();
    slide .addText([
          {text: 'test A & B', options: {hyperlink: {url: 'https://github.com/gitbrent/pptxgenjs?a=1&b=2', tooltip: ' A&B'}}}
          ], {x: 0.62, y: 1, w: 5.3, h: 0.34, font_size: 14, color: '667184', bullet: {code: '27A2'}}
     );
pptx.save('testhyperlink');

Doesn't work due to "a=1&b=2" in the url.

In the linked issue, a suggestion was that there was a missing decodeXmlEntities(rel.Target) call somewhere in the library.

@gitbrent gitbrent self-assigned this Sep 13, 2019
@gitbrent gitbrent added this to the 3.0.0 milestone Sep 13, 2019
@gitbrent
Copy link
Owner

Thanks @Tehnix

This is now fixed and will be released with v3.0

ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants