Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error ' Object doesn't support property or method 'startsWith'' in IE 11 #648

Closed
YakQin opened this issue Jan 14, 2020 · 5 comments
Closed
Assignees
Milestone

Comments

@YakQin
Copy link

YakQin commented Jan 14, 2020

Hello,

'startsWith' is ES 6 method but it is fund in the pptxgen.min.js file, due to this it is not working with IE 11, though I included promise.min.js

@gitbrent gitbrent self-assigned this Jan 14, 2020
@gitbrent gitbrent added this to the 3.1.0 milestone Jan 14, 2020
gitbrent added a commit that referenced this issue Jan 14, 2020
@gitbrent
Copy link
Owner

Thanks for reporting this @YakQin !

I've checked in a fix and will review it on an IE11 equipped PC tomorrow to look for further issues.

@YakQin
Copy link
Author

YakQin commented Jan 14, 2020

Thanks a lot for the quick response. There are a lot of ES6 syntax like 'endsWith', 'entries' etc. At the moment I will use the old versions.
Looking forward to the fix for IE 11 (though we don't like it)

gitbrent added a commit that referenced this issue Jan 17, 2020
@gitbrent
Copy link
Owner

@YakQin - all fixed

  • removed ES6 code from demo index.html
  • fixed stylesheet as media query prevented loading any styles
  • bundle now built with babel polyfill proving full IE11 support

The master bundle should be working for you now.

@YakQin
Copy link
Author

YakQin commented Jan 17, 2020

Thanks a lot, now it worked in IE 11, you might also need to update the CDN file : https://cdn.jsdelivr.net/gh/gitbrent/pptxgenjs@master/dist/pptxgen.bundle.js

Also noticed you changed from promise.min.js to polyfill.min.js in the libs folder so you might need to update the html for index.html as well (just to avoid potential confusion :) )

@gitbrent
Copy link
Owner

Thanks for the verification.

I'm getting the demo refs and other items ready for 3.1 - appreciate the reminder :)

ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
ericrockey pushed a commit to WeTransfer/PptxGenJS that referenced this issue Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants