Demo page update #164
Closed
Demo page update #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # README.md # dist/pptxgen.bundle.js # dist/pptxgen.bundle.js.map # dist/pptxgen.js # examples/pptxgenjs-demo.js
# Conflicts: # README.md # dist/pptxgen.bundle.js # dist/pptxgen.bundle.js.map # dist/pptxgen.js
|
Hi @clubajax , The library needs to retain IE11 compatibility for now, so can you use a non-flex layout? |
gitbrent
approved these changes
Sep 10, 2017
gitbrent
pushed a commit
that referenced
this pull request
Sep 10, 2017
|
Thanks @clubajax ! I ended-up siwtching to Flex on the individual tab fieldsets as well, so the whole page display nicely on any size screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made minor change to the demo HTML page to persist the tab selection across refreshes. This is a critical feature since this page doubles as the unit tests. On small screens all the button clicking gets a bit painful.
Also tweaked the tabs CSS to be more responsive an not collapse.