Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added image type to shapes to allow images to be placed on top of shapes, added more properties to ppt document #53

Closed
wants to merge 2 commits into from

Conversation

ericwgreene
Copy link

When creating masters, images are processed before shapes causing all images to appear below shapes when a shape and images occupy the same location on the slide. Adding a shape type of image in the same manner as text resolves this problem by allowing stacking according to the array order.

@ericwgreene ericwgreene changed the title added image type to shapes to allow images to be placed on top of shapes added image type to shapes to allow images to be placed on top of shapes, added more properties to ppt document Mar 9, 2017
@gitbrent gitbrent self-assigned this Mar 10, 2017
@gitbrent gitbrent added this to the v1.2.2 milestone Mar 10, 2017
gitbrent pushed a commit that referenced this pull request Mar 10, 2017
@gitbrent
Copy link
Owner

Hi @ericwgreene ,

Thanks for opening this issue/request. The issue is fixed now, although I'm not pulling this code as i did a more intensive re-write of the master building code that addresses other issues with ordering as well.

Try it now and let me know if it works for you.

The demo page (pptxgenjs-demo.html) Masters section shows images over shapes now as well.

@ericwgreene
Copy link
Author

Can you add support for the additional properties which I included in my second commit?

@gitbrent
Copy link
Owner

Oh, i see. Because of the way the Masters build their objects in sets (all images, all shapes, etc.) you can't interleave objects and images.

Given that, the larger solution is to modify the way Master Slides ingest objects to a become a single set that can have a mixture of types.

The degree of complexity being utilized in masters by yourself and others makes re-working the master params a worthwhile endeavor, so i'll start work and let you know when i've got something for you to test with.

Thanks!

@ericwgreene
Copy link
Author

Exactly. Also, I added some additional property settings for company, author, subject, etc... Can you add those as well?

gitbrent pushed a commit that referenced this pull request Mar 11, 2017
@gitbrent gitbrent modified the milestones: 1.3.0, v1.2.2 Mar 11, 2017
gitbrent pushed a commit that referenced this pull request May 1, 2017
@gitbrent
Copy link
Owner

gitbrent commented May 1, 2017

Hi @ericwgreene ,

Thanks again for the requests.

Slide Master objects can now be added in any order and build up in a sensible manner.

Slide Master Examples and Demo page updated to show the new methodology.

@gitbrent gitbrent closed this May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants